Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Get cluster config from configmap when managing service with paictl. #1489

Merged
merged 12 commits into from
Oct 16, 2018

Conversation

ydye
Copy link
Contributor

@ydye ydye commented Oct 15, 2018

  • Broken Change
    • paictl service will remove the parameter -p /path/to/cluster/configuration/dir. And add the new parameter -c /path/to/kubeconfig to pass the path of kubeconfig.
    • paictl service will get cluster configuration from kubernetes. Depends on the feature of configuration storage, admin could use the command paictl config to manage the cluster configuration, such as push, pull and generate.
    • configuration storage feature is forced enable after this change. So if you do not store your configuration into your kubernetes cluster, please push your configuration into the cluster first.

@ydye ydye requested a review from hao1939 October 15, 2018 07:20
@coveralls
Copy link

coveralls commented Oct 15, 2018

Coverage Status

Coverage increased (+0.01%) to 51.632% when pulling 0b6d318 on yuye/paictl-service-change into b7df7bd on master.

@ydye ydye merged commit fcb41fc into master Oct 16, 2018
@ydye ydye deleted the yuye/paictl-service-change branch October 17, 2018 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants