Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Drivers] Make drivers version configurable #1626

Merged
merged 13 commits into from
Nov 1, 2018
Merged

[Drivers] Make drivers version configurable #1626

merged 13 commits into from
Nov 1, 2018

Conversation

ydye
Copy link
Contributor

@ydye ydye commented Oct 30, 2018

No description provided.

wangcan0329
wangcan0329 reviewed Oct 30, 2018
View reviewed changes
Copy link
Contributor

@wangcan0329 wangcan0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the file path to src/drivers/build/drivers-384.111.dockerfile instead of src/drivers-384.111/build/drivers.dockerfile? PAI-build can support build multiple images in one services.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.767% when pulling b42bdc5 on yuye/drivers-upgrade into 521e6ac on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.767% when pulling b42bdc5 on yuye/drivers-upgrade into 521e6ac on master.

@coveralls
Copy link

coveralls commented Oct 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+25.8%) to 77.535% when pulling 33b5d2e on yuye/drivers-upgrade into 521e6ac on master.

@ydye
Copy link
Contributor Author

ydye commented Oct 30, 2018

@wangcan0329 Done

@fanyangCS
Copy link
Contributor

shall we add a document to explain how to change driver version?

@ydye
Copy link
Contributor Author

ydye commented Oct 31, 2018

@fanyangCS
Add some notification in the cluster configuration https://github.com/Microsoft/pai/blob/3d03ce34be82b5a8009228cf6c07bdcc58bbf1b0/examples/cluster-configuration/services-configuration.yaml#L103

I prefer to write more concrete document after the developing of cluster object model

@ydye ydye changed the title Make drivers version configurable [Drivers] Make drivers version configurable Oct 31, 2018
@ydye
Copy link
Contributor Author

ydye commented Nov 1, 2018

@fanyangCS The document is added in another PR. #1632

@ydye ydye merged commit c7fc0cd into master Nov 1, 2018
@ydye ydye deleted the yuye/drivers-upgrade branch November 1, 2018 03:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wangcan0329 wangcan0329 wangcan0329 approved these changes

@xudifsd xudifsd Awaiting requested review from xudifsd

@hao1939 hao1939 Awaiting requested review from hao1939

@fanyangCS fanyangCS Awaiting requested review from fanyangCS

@sterowang sterowang Awaiting requested review from sterowang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ydye @coveralls @fanyangCS @wangcan0329