Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

add imagePullSecrets to prometheus #1678

Merged
merged 1 commit into from
Nov 8, 2018
Merged

add imagePullSecrets to prometheus #1678

merged 1 commit into from
Nov 8, 2018

Conversation

xudifsd
Copy link
Member

@xudifsd xudifsd commented Nov 8, 2018

fix #1639

@xudifsd xudifsd requested a review from hao1939 November 8, 2018 03:44
@xudifsd
Copy link
Member Author

xudifsd commented Nov 8, 2018

@hao1939 last time you changed both node-exporter and prometheus, I already checked node-exporter already have imagePullSecrets since job-exporter requires it.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.2%) to 65.966% when pulling ac7594f on dixu/fix-prometheus-secret into 339c59b on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+14.2%) to 65.966% when pulling ac7594f on dixu/fix-prometheus-secret into 339c59b on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.2%) to 65.966% when pulling ac7594f on dixu/fix-prometheus-secret into 339c59b on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.2%) to 65.966% when pulling ac7594f on dixu/fix-prometheus-secret into 339c59b on master.

@xudifsd xudifsd mentioned this pull request Nov 8, 2018
Closed
@xudifsd xudifsd merged commit 498b1ce into master Nov 8, 2018
@xudifsd xudifsd deleted the dixu/fix-prometheus-secret branch November 8, 2018 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hao1939 hao1939 hao1939 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prometheus image can't pull
3 participants
@xudifsd @coveralls @hao1939