This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
PAI webportal plugin, make marketplace a plugin. #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerhut
force-pushed
the
qixcheng/webportal/plugin
branch
from
8e0c5d0 to
1a900eb
Compare
Gerhut
changed the title
Gerhut
force-pushed
the
qixcheng/webportal/plugin
branch
from
1a900eb to
43a413f
Compare
Gerhut
force-pushed
the
qixcheng/webportal/plugin
branch
from
43a413f to
271f408
Compare
|
Rebased on current object model |
Gerhut
force-pushed
the
qixcheng/webportal/plugin
branch
from
271f408 to
50f0e43
Compare
wangcan0329
approved these changes
Dec 26, 2018
wangcan0329
added a commit
that referenced
this pull request
Jan 4, 2019
This reverts commit 22a0e1b.
hao1939
pushed a commit
that referenced
this pull request
Jan 8, 2019
* Add plugin support * Rename env.js to env.js.template to avoid eslint * Make marketplace a web portal plugin * web portal: recover plugin doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some further works to do
WEBPORTAL_PLUGINSenvironment variable needs to be a JSON formatted list, currently we can only serialize the list to JSON string inpaiObjectModel.py. I will move the serialization to templatewebportal.yaml.templatewhen jinja'stojsonfilter (introduced in jinja 2.9, currently we are using 2.8) is available to use. (Perhaps mounting a configmap is better.)paiObjectModel.py, will move to web portal's default config when new object model is landed.