This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of #1764 , fixed #889 can partially solve #1719 .
I split monolithic job-exporter into 4 threads:
We utilize python3's timeout parameter of check_output, so hopefully no single external command call will hangs indefinitely. I have already tuned the timeout parameter of each command call by using 99th latency of calling each command plus some buffer time.
Also since we use multi-threaded model, no hangs in single collector will block other collector from emitting metrics.