This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Escape injected variables in shell scripts #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sterowang
reviewed
Dec 10, 2018
|
The bottom one is for backward compatibility |
sunqinzheng
suggested changes
Dec 10, 2018
sunqinzheng
suggested changes
Dec 10, 2018
sunqinzheng
reviewed
Dec 11, 2018
| echo PAI_DEFAULT_FS_URI={{ hdfsUri }} >> $ENV_LIST | ||
| echo PAI_JOB_NAME={{ jobData.jobName }} >> $ENV_LIST | ||
| echo PAI_USER_NAME={{ jobData.userName }} >> $ENV_LIST | ||
| echo PAI_DATA_DIR={{ jobData.dataDir }} >> $ENV_LIST |
There was a problem hiding this comment.
User can set/modify arbitrary environment variable here because the job data will be unescaped by echo.
(I don't know how to make use of it...)
There was a problem hiding this comment.
Job env will be only enabled in docker containers, so I think any unpredicted modifications will be safe.
sunqinzheng
approved these changes
Dec 11, 2018
Gerhut
force-pushed
the
qixcheng/rest-server/shell-inject
branch
from
54767ab to
b62d00a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.