Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Webportal]fix user-view datatable display bug #734

Merged
merged 3 commits into from
Jun 14, 2018

Conversation

wangcan0329
Copy link
Contributor

No description provided.

@wangcan0329 wangcan0329 requested review from hwuu and abuccts June 14, 2018 09:48
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 45.45% when pulling 54bed4e on canwan/add-user-list-page into f1ac564 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 45.45% when pulling 54bed4e on canwan/add-user-list-page into f1ac564 on master.

@coveralls
Copy link

coveralls commented Jun 14, 2018

Coverage Status

Coverage increased (+0.7%) to 50.76% when pulling 6ab4ee3 on canwan/add-user-list-page into f1ac564 on master.

@wangcan0329 wangcan0329 requested a review from Gerhut June 14, 2018 09:55
@@ -254,7 +256,7 @@ window.updateUserAccount = updateUserAccount;
const resizeContentWrapper = () => {
$('#content-wrapper').css({'height': $(window).height() + 'px'});
if (table != null) {
$('.dataTables_scrollBody').css('height', (($(window).height() - 265)) + 'px');
$('.dataTables_scrollBody').css('height', (($(window).height() - 315)) + 'px');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let’s remove this magic number in the future.

Copy link
Member

@Gerhut Gerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refine with CSS in the future.

@wangcan0329 wangcan0329 merged commit d7682f5 into master Jun 14, 2018
@wangcan0329 wangcan0329 deleted the canwan/add-user-list-page branch June 14, 2018 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants