Cannot debug VFT inself anymore - FSharp.Editor has no PDB file

[vasily-kirichenko]

• git cleanup
• deleted c:\Users\me\AppData\Local\Microsoft\VisualStudio\15.0_183b437fFSharpDev
• deleted c:\Users\me\AppData\Roaming\Microsoft\VisualStudio\15.0_183b437fFSharpDev
• build vs
• build VFT solution inside VS
• Ctrl+F5
• attached to the exp instance
• tried to set a breakpoint in several places in FSharp.Editor and FSharp.Language.Service

[forki]

Yes I noticed that as well. Since very recently I can't debug the compiler. Usually I do: * git clean -xdf * build debug * open vs * set Fsc as startup project * F5 I thought I messed up my settings, but since you see something similar... Am 02.04.2017 10:26 schrieb "Vasily Kirichenko" <[email protected]>:

…

- git cleanup - deleted c:\Users\me\AppData\Local\Microsoft\VisualStudio\15.0_ 183b437fFSharpDev - deleted c:\Users\me\AppData\Roaming\Microsoft\VisualStudio\15.0_ 183b437fFSharpDev - build vs - build VFT solution inside VS - Ctrl+F5 - attached to the exp instance - tried to set a breakpoint in several places in FSharp.Editor and FSharp.Language.Service [image: image] <https://cloud.githubusercontent.com/assets/873919/24585569/ca120d20-1796-11e7-8ced-abfd46cb9cca.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2771>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNKrje5ioAT7riOSjNa5HOG_HYLjBks5rr1vCgaJpZM4MwvJE> .

[vasily-kirichenko]

wow :((

[forki]

Ok so we should investigate if older commits still work. If so we probably find the one using bisect Am 02.04.2017 10:30 schrieb "Vasily Kirichenko" <[email protected]>:

…

wow :(( — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNApwQ6_MEpI83TgxVZjFIZOO3CdFks5rr1yrgaJpZM4MwvJE> .

[vasily-kirichenko]

I think the big diff was switching to more nuget VS packages instead of GAC deps.

[forki]

Sigh.
I think @cloudRoutine said something about nuget packages messing up his editor support yesterday. Why is this shit never working?
OK so what now? Can you reset before that and confirm it broke us?

[vasily-kirichenko]

[vasily-kirichenko]

I'm completely stuck on working on VFT at the moment :(

[cloudRoutine]

tried adding

<IncludeDebugSymbolsInVSIXContainer>true</IncludeDebugSymbolsInVSIXContainer>
  <IncludeDebugSymbolsInLocalVSIXDeployment>true</IncludeDebugSymbolsInLocalVSIXDeployment>

to visualfsharpopensource.csproj, only seemed to make symbols load faster

after disabling just my code in debug settings

Changing the setting suggested in the image below made no difference

[cloudRoutine]

After trying to set a breakpoint crashed VS

I was able to set some breakpoints that came up as invalid while loading the experimental instance once it was actually running

[vasily-kirichenko]

I looked at what FSharp.Editor.dll is actually loaded and there no *.pdb in that folder at all:

[vasily-kirichenko]

I've copied *.pdb manually, it's not helped.

[vasily-kirichenko]

'devenv.exe' (CLR v4.0.30319: DefaultDomain): Loaded 'C:\USERS\VASKI\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_183B437FFSHARPDEV\EXTENSIONS\MICROSOFT.VISUALFSHARPTOOLS\VISUAL F# TOOLS\42.42.42.42\FSharp.Editor.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.

Why the hell it's optimized??

[sergey-tihon]

not sure if it is related, but after update to latest nightly, VS2017 asked to install some VS updates ...
After installation I cannot open solutions with F# projects and I found that VFT extension is disables

I can not do anything about it for now...

[cartermp]

@sergey-tihon Can you run VSIXInstaller to remove the nightly and load F# projects after that? (It should be using the vs2017 RTW version of the tools).

[cloudRoutine]

cc @ctaggart

[cloudRoutine]

switching back to my navigable-improvements branch/PR and the problem disappears

so the problem should be within
cloudRoutine/fsharp@navigable-improvements...cloudRoutine:master

[0x53A]

There seems to be an issue with portable PDBs:

After disabling optimizations and setting DebugType: full, all breakpoints bind, and all except two (the marked lines) also actually hit.

master...0x53A:debuggable

I had to disable sourcelink, because sourcelink only works with portable pdbs.

With optimizations enabled, some breakpoints wouldn't bind, but the ones that bound then also got hit.

[majocha]

Thanks @0x53A ! It started to work with your fix, but only after another git clean.

[0x53A]

@majocha you don't need to clean, but you need to change anything in any file, because the up-to-date check doesn't check the FSharpSource.Settings.targets, and so doesn't rebuild by default. I always just added/removed one space in FSharp.Editor when testing this.

[forki]

clean is often needed if you want to rebuild proto or when nuget fucked up again.

[forki]

This is really really painful

[majocha]

Yeah, I'm totally blocked again. Breakpoints fail to bind.

[cartermp]

cc @KevinRansom @brettfo - this has to be resolved quickly.

[vasily-kirichenko]

Fixed in master.