Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename is bogus on generic parameters #5389

Closed
asik opened this issue Jul 26, 2018 · 2 comments · Fixed by #6491
Closed

Rename is bogus on generic parameters #5389

asik opened this issue Jul 26, 2018 · 2 comments · Fixed by #6491

Comments

@asik
Copy link
Contributor

asik commented Jul 26, 2018

type Generic<'t> = {
    T : 't
}

After invoking rename (Ctrl+R,R) on t or 't and entering a or 'a respectively, the result is invalid code:

type Generic<``'a``> = {
    T : ``'a``
}

The expected result is

type Generic<'a> = {
    T : 'a
}

Visual Studio 15.7.5

@cartermp
Copy link
Contributor

FYI @Krzysztof-Cieslak although we handle the resulting symbol differently in VS, this will also give an incorrect result in Ionide. Any ideas if this is due to how you handle the result?

ionide

@Krzysztof-Cieslak
Copy link
Contributor

I think Ionide problem may be connected with some underlying behavior of VSCode, not with how we handle results in it.

@cartermp cartermp added this to the 16.0 milestone Jul 29, 2018
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants