-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed binary reader error message #1468
Conversation
Hi @ncave, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
That's kind of a weird failure: @dotnet-bot test this please. |
@ncave |
@KevinRansom Tests had to be fixed. |
@dotnet-bot test this please |
@KevinRansom I think the error in the AppVeyor ci_part2 build is unrelated to this PR, because I see the same error in a lot of other recent PRs:
|
@ncave ... yep I agree. Thank you for taking care of this Kevin |
Make all binary reader error messages the same (like this one) so they show the actual error, otherwise the actual error is obscured and hidden.