Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsce package should not check for publisher #328

Closed
octref opened this issue Jan 29, 2019 · 7 comments
Closed

vsce package should not check for publisher #328

octref opened this issue Jan 29, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities released
Milestone

Comments

@octref
Copy link
Contributor

octref commented Jan 29, 2019

Repro:

@joaomoreno joaomoreno self-assigned this Jan 30, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Jan 30, 2019
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jan 30, 2019
@bkelley13
Copy link

For extension packs, too.

1 similar comment
@bsed
Copy link

bsed commented Jul 1, 2019

For extension packs, too.

@joaomoreno joaomoreno removed this from the Backlog milestone Oct 11, 2019
vojtechkral added a commit to vojtechkral/vscode-vsce that referenced this issue Sep 16, 2020
@Supitto
Copy link

Supitto commented Jan 13, 2021

You can solve this by adding a 'publisher' field in package.json, vsce will generate the package with no problems

@SimoneRichetti
Copy link

I agree with the issue too. If I use a private npm repository to share my extension only with my colleagues I don't want to create an Azure organization. This check should be done when I publish to the public marketplace, not when I generate the vsix package.

@SimoneRichetti
Copy link

Hi @sergeiudris, I had that error for two reasons:

  1. My publisher name was not correct: only letters, numbers and hyphens are allowed;
  2. I put local images in the README of the extension, which is not allowed, you can only put https links.

Maybe these tips are helpful. I link you the issue that I opened on another repo but correlated to this problem: joelspadin-garmin/vscode-private-extension-manager#40 (comment)

@SimoneRichetti
Copy link

You are welcome!
I think that a lot of people are falling into this error. Maybe a mention of that should be added to the documentation? I mention @joaomoreno as the assignee of the issue.

@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Mar 24, 2021
@joaomoreno joaomoreno added this to the November 2021 milestone Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants