fix: ensure that we can define dependency argument in config #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joaomoreno If you can take a look at this it would be awesome, that is a real blocker for our switch from npm to yarn for building, as we cannot add custom command line arguments to vsce calls. |
joaomoreno
approved these changes
Jun 17, 2022
joaomoreno
requested changes
Jun 17, 2022
alexdima
approved these changes
Jun 17, 2022
joaomoreno
approved these changes
Jun 17, 2022
|
Sadly I am unable to request the failed job rerun. I am sure it was a glitch and that has nothing to do with this PR. |
|
Please approve GHA run. |
|
Any chance to get this merged? Asking as I do not want to miss it from the next release. Thanks! |
|
🎉 This PR is included in version 2.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commander documentation states that when using negative commands, if you do not already have a non-negative command it sets the default to
true, which is what broke the logic for loading defaults frompackage.json.Fixes: #742
Reference: https://www.npmjs.com/package/commander#other-option-types-negatable-boolean-and-booleanvalue