Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Make vmArgs accept an array #389

Closed
PeterLaComb-Availity opened this issue Aug 29, 2018 · 1 comment
Closed

Feature Proposal: Make vmArgs accept an array #389

PeterLaComb-Availity opened this issue Aug 29, 2018 · 1 comment
Assignees
Milestone

Comments

@PeterLaComb-Availity
Copy link

I would like to propose that vmArgs accept an Array as an alternative to the current String. Keep the string for compatibility reasons, but allow an array because some projects accept a large number of arguments that would be easier to look at if presented as an array.

@andxu
Copy link
Contributor

andxu commented Sep 10, 2018

The PR is attached, to test it, add the following properties to launch.json of test case ArgsTest(in TestPlan.md)

 "mainClass": "ArgsTest",
  "args": ["a b", "foo \\\"bar"],
 "vmArgs": ["-Xms64M",  "-Xmx128M",  "-Dfoo= \\bar"]

Add the following statement to get the properties:

  String foo = (String) System.getProperties().get("foo");

the variables should be like this:

image

Please be careful that the bad vmArgs may cause the program fail to start, eg: "vmArgs": ["-Xms64M", "-Xmx128M", "-Dfoo= "bar"], it is by-design and can also be reproduced at eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants