Support step filter when stepping #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <[email protected]>
|
Peer PR on server side: microsoft/java-debug#106
|
yaohaizh
suggested changes
Nov 17, 2017
README.md
Outdated
| @@ -56,6 +56,11 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht | |||
| - `projectName` - The preferred project in which the debugger searches for classes. There could be duplicated class names in different projects. This setting also works when the debugger looks for the specified main class when launching a program. | |||
| - `cwd` - The working directory of the program. | |||
| - `env` - The extra environment variables for the program. | |||
| - `debugFilters` - Customize the filters to debug "Just My Code". | |||
There was a problem hiding this comment.
Should avoid the "Just My Code". The "Just My Code" is .net term and has different behavior from here. We should avoid the confusion.
README.md
Outdated
| @@ -56,6 +56,11 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht | |||
| - `projectName` - The preferred project in which the debugger searches for classes. There could be duplicated class names in different projects. This setting also works when the debugger looks for the specified main class when launching a program. | |||
| - `cwd` - The working directory of the program. | |||
| - `env` - The extra environment variables for the program. | |||
| - `debugFilters` - Customize the filters to debug "Just My Code". | |||
| - `stepFilters` - Skip these classes when stepping. Each filter could be fully qualified class name or pattern. Example: [\"java.lang.ClassLoader\", \"java.*\"]. | |||
There was a problem hiding this comment.
Should be more detail information about the pattern that can be applied here? Regex?
README.md
Outdated
| @@ -56,6 +56,11 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht | |||
| - `projectName` - The preferred project in which the debugger searches for classes. There could be duplicated class names in different projects. This setting also works when the debugger looks for the specified main class when launching a program. | |||
| - `cwd` - The working directory of the program. | |||
| - `env` - The extra environment variables for the program. | |||
| - `debugFilters` - Customize the filters to debug "Just My Code". | |||
| - `stepFilters` - Skip these classes when stepping. Each filter could be fully qualified class name or pattern. Example: [\"java.lang.ClassLoader\", \"java.*\"]. | |||
| - `skipSynthetics` - Skip synthetic methods when stepping. | |||
There was a problem hiding this comment.
What is synthetic methods?
There was a problem hiding this comment.
Signed-off-by: Jinbo Wang <[email protected]>
Signed-off-by: Jinbo Wang <[email protected]>
yaohaizh
previously approved these changes
Nov 22, 2017
andxu
previously approved these changes
Dec 1, 2017
akaroml
requested changes
Dec 6, 2017
README.md
Outdated
| @@ -61,6 +61,11 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht | |||
| - `internalConsole` - VS Code debug console (input stream not supported). | |||
| - `integratedTerminal` - VS Code integrated terminal. | |||
| - `externalTerminal` - External terminal that can be configured in user settings. | |||
| - `stepFilters` - Customize the filters to skip the specified methods and classes when stepping. | |||
There was a problem hiding this comment.
"Skip specified classes or methods when stepping."
README.md
Outdated
| @@ -61,6 +61,11 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht | |||
| - `internalConsole` - VS Code debug console (input stream not supported). | |||
| - `integratedTerminal` - VS Code integrated terminal. | |||
| - `externalTerminal` - External terminal that can be configured in user settings. | |||
| - `stepFilters` - Customize the filters to skip the specified methods and classes when stepping. | |||
| - `classNameFilters` - Skip these classes when stepping. Each filter could be fully qualified class name or regular expression that begins with '\*' or ends with '\*'. Example: [\"java.lang.ClassLoader\", \"java.*\"]. | |||
There was a problem hiding this comment.
Skip the specified classes when stepping. Class names should be fully qualified. Wildcard is supported.
akaroml
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Add debugFilters options in launch.json to allow user to customize the filters to debug "Just My Code".