Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion list for version is not well-sorted. #236

Closed
Eskibear opened this issue Jan 29, 2019 · 0 comments · Fixed by #237
Closed

Completion list for version is not well-sorted. #236

Eskibear opened this issue Jan 29, 2019 · 0 comments · Fixed by #237
Milestone

Comments

@Eskibear
Copy link
Member

By design, the version should be sorted in reverse order of the semantic version, with the latest version on the top. If it's not a semantic version, sort in alphabetical order.

Semantic version format is major.minor.patch-identifier. BUT, for Spring-boot artifacts, official versions are major.minor.patch.identifier, e.g. "2.1.0.RELEASE". So finally the versions are sorted in alphabetical order.

My suggestion is to have a more robust version parser. E.g. split by . and -, and numeric values are recognized as major, minor, patch by turns. The rest part can be regarded as identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant