Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Maven view by default #51

Closed
chambery opened this issue May 10, 2018 · 3 comments
Closed

Hide Maven view by default #51

chambery opened this issue May 10, 2018 · 3 comments
Assignees
Milestone

Comments

@chambery
Copy link

Maven Projects view should hide if the project isn't Maven-enabled. I added when to the package.json :

		"views": {
			"explorer": [
				{
					"id": "mavenProjects",
					"name": "Maven Projects",
					"when": "workspaceContains:pom.xml"
				}

which succeeds in hiding when I don't have a Maven project, but doesn't show in the view contributions list when I load my Java project containing a pom.xml.

@Eskibear
Copy link
Member

As far as I know, workspaceContains:${toplevelfilename} is a kind of ActivationEvents, not supposed to be used in when conditional.

Ref:
https://code.visualstudio.com/docs/extensionAPI/activation-events#_activationeventsworkspacecontains

About hiding the view by default, there's a related issue #36 . And since there's new APIs in v1.23, we're considering whether to put it into a separate view for better experience.

@Eskibear Eskibear self-assigned this Jul 12, 2018
@Eskibear
Copy link
Member

can be done by Context value, value is set by command.setContext API

@Eskibear
Copy link
Member

fixed in #80

@Eskibear Eskibear added this to the 1.0.0 milestone Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants