Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for WSL #143

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

RobertDeRose
Copy link
Contributor

  • Changed currentWindowsShell to be more generic and straighforward
  • Changed toWSLPath to return path converting \ to / even when
    not containing a :\\

closes #142

* Changed `currentWindowsShell` to be more generic and straighforward
* Changed `toWSLPath` to return path converting `\` to `/` even when
  not containing a `:\\`
@msftclas
Copy link

msftclas commented Nov 9, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@Eskibear Eskibear merged commit 810cc0c into microsoft:master Nov 12, 2018
@RobertDeRose
Copy link
Contributor Author

Thanks for the merge!

@RobertDeRose RobertDeRose deleted the bugfix/better-wsl-support branch November 12, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven goals fail to execute when using WSL bash for Terminal
3 participants