Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [email protected] to fix vulnerability issue of event-stream. #154

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

Eskibear
Copy link
Member

To resolve the alert.

Vulnerable versions: > 3.3.4
Patched version: No fix
The NPM package flatmap-stream is considered malicious. A malicious actor added this package as a dependency to the NPM event-stream package in versions 3.3.6 and later. Users of event-stream are encouraged to downgrade to the last non-malicious version, 3.3.4.

Users of flatmap-stream are encouraged to remove the dependency entirely.

@@ -363,7 +363,7 @@
"tslint": "^5.8.0",
"tslint-microsoft-contrib": "^5.0.1",
"typescript": "^2.9.2",
"vscode": "^1.1.21"
"vscode": "^1.1.22"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to update vscode?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dependency is introduced by vscode.

$> npm ls event-stream
[email protected] /Users/sechs/Documents/vscode-maven
└─┬ [email protected]
  ├─┬ [email protected]
  │ └── [email protected]
  ├─┬ [email protected]
  │ └── [email protected]  deduped
  ├─┬ [email protected]
  │ └── [email protected]  deduped
  └─┬ [email protected]
    └── [email protected]  deduped

@Eskibear Eskibear merged commit 0129f64 into microsoft:master Nov 27, 2018
@Eskibear Eskibear deleted the fix-event-stream branch November 27, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants