Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide users to setup correct mvn executable path #66

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

Eskibear
Copy link
Member

@Eskibear Eskibear commented Jul 3, 2018

related issue #65

@Eskibear Eskibear self-assigned this Jul 3, 2018
@Eskibear Eskibear requested a review from jdneo July 3, 2018 08:30
src/extension.ts Outdated
const OPTION_GUIDE: string = "Guidance";
const choice: string = await vscode.window.showErrorMessage("Unable to execute Maven commands. Please make sure Maven is either in the PATH, or that 'maven.executable.path' is pointed to its installed location. Also make sure JAVA_HOME is specified either in environment variables or settings.", OPTION_SHOW_DETAILS);
if (choice === OPTION_SHOW_DETAILS) {
const choice2: string = await vscode.window.showErrorMessage(error.message, OPTION_GUIDE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name for choice2?

@Eskibear Eskibear merged commit 703fbbc into microsoft:master Jul 4, 2018
@Eskibear Eskibear deleted the pr_guide branch July 4, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants