Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt when an "unsafe" workspace python environment is to be autoselected #10879

Closed
Tracked by #11015
karrtikr opened this issue Mar 31, 2020 · 0 comments
Closed
Tracked by #11015
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality

Comments

@karrtikr
Copy link

karrtikr commented Mar 31, 2020

Unsafe environments would be any environment that could be easily downloaded to user's development environment (e.g. by means of source control). The assumption is that this is the case of environments that are stored in the workspace.

"We found a Python environment in this workspace. Do you want to select it to start up the features in the Python extension? Only accept if you trust this environment."
Button options: Yes, No, Learn More, Do not show again.

  • Clicking “yes” will update the path to the interpreter in the persistent store.

  • Clicking “no” will will trigger the “select interpreter” prompt we currently display when there’s no interpreter selected in the workspace. It should also flag the value for pythonPath to be unsafe.

  • Clicking “learn more” will point users to the Environments section of our documentation, which will be updated to explain how interpreter selection and tools execution work with the Python extension.

  • Closing the notification prompt will be considered the same as “no”

  • Clicking "Do not show again" will stop this to be prompted on every workspace.

the prompt will be displayed only once per workspace

@karrtikr karrtikr added feature-request Request for new features or functionality needs PR triage-needed Needs assignment to the proper sub-team area-environments Features relating to handling interpreter environments labels Mar 31, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Mar 31, 2020
@karrtikr karrtikr mentioned this issue Apr 7, 2020
21 tasks
@karrtikr karrtikr self-assigned this Apr 17, 2020
@ghost ghost removed the needs PR label May 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

1 participant