Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle when widget is found on CDN, but downloading fails or times out #1968

Closed
greazer opened this issue Apr 20, 2020 · 2 comments
Closed

Gracefully handle when widget is found on CDN, but downloading fails or times out #1968

greazer opened this issue Apr 20, 2020 · 2 comments
Assignees
@rchiodo

Comments

@greazer
Copy link
Member

greazer commented Apr 20, 2020

No description provided.

@rchiodo
Copy link
Contributor

rchiodo commented Apr 20, 2020 •
edited by DonJayamanne
Loading

Looking at the code and the console logs on microsoft/vscode-python#11247 it looks like the CDN can get a 429 - too many requests.

  • We're discussing download the source ourselves instead and saving it next to the extension in a hashed location.
  • Possibly attempt to download from jsdelivr as well as unpkg at the same time (in case one is slower than the other, or similar)

@rchiodo rchiodo self-assigned this Apr 20, 2020
@IanMatthewHuff
Copy link
Member

Validated.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IanMatthewHuff @greazer @rchiodo