Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full file path sent in telemetry (when running tests) #1180

Closed
DonJayamanne opened this issue Mar 24, 2018 · 0 comments · Fixed by #1197
Closed

Full file path sent in telemetry (when running tests) #1180

DonJayamanne opened this issue Mar 24, 2018 · 0 comments · Fixed by #1197
Assignees
@brettcannon @DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
March 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 24, 2018 •
edited
Loading

The fully qualified file path is sent in telemetry when capturing usage of unit test run feature.
(file path sent in trigger)

@brettcannon FYI
This will need to be fixed in March release.
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 24, 2018
@DonJayamanne DonJayamanne added this to the March 2018 milestone Mar 24, 2018
@DonJayamanne DonJayamanne mentioned this issue Mar 26, 2018
Merged
5 tasks
DonJayamanne added a commit that referenced this issue Mar 26, 2018
@DonJayamanne
Ensure file paths are not sent in telemetry when running unit tests (#…
e2b9037 
…1197)

* 🐛 1st arg of command handlers is {} or Uri based on how invoked
* 📝 change log
* Fixes #1180
@DonJayamanne DonJayamanne mentioned this issue Mar 27, 2018
Closed
@DonJayamanne DonJayamanne mentioned this issue May 15, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brettcannon brettcannon

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Ensure file paths are not sent in telemetry when running unit tests DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne