Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis engine breaks method and variable extraction #1774

Closed
brettcannon opened this issue May 29, 2018 · 2 comments · Fixed by #1801
Closed

Analysis engine breaks method and variable extraction #1774

brettcannon opened this issue May 29, 2018 · 2 comments · Fixed by #1801
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug

Comments

@brettcannon
Copy link
Member

Environment data

  • VS Code version: insiders
  • Extension version (available under the Extensions sidebar): master
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Relevant/affected Python packages and their versions: rope 0.10.7

Actual behavior

Nothing happens

Expected behavior

A refactoring occurs.

Steps to reproduce:

example

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

Starting the analysis engine.
[Info  - 13:43:15] Created Microsoft.PythonTools.Interpreter.Ast.AstPythonInterpreter instance from Microsoft.PythonTools.Interpreter.Ast.AstPythonInterpreterFactory
Initializing for c:\Users\_\Desktop\some bunk\.venv\Scripts\python.exe
Loading files from c:\Users\_\Desktop\some bunk

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)


@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR labels May 29, 2018
@MikhailArkhipov
Copy link

@DonJayamanne - activateSimplePythonRefactorProvider - can it be registered in all cases?

@MikhailArkhipov
Copy link

Just need to register refactoring provider in all cases. It does not depend on Jedi.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants