Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in debugger Banner Error: Missing required @injectable annotation in: Random. #2557

Closed
d3r3kk opened this issue Sep 12, 2018 · 0 comments · Fixed by #2558
Closed

Error in debugger Banner Error: Missing required @injectable annotation in: Random. #2557

d3r3kk opened this issue Sep 12, 2018 · 0 comments · Fixed by #2558
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2018, week 36 - S...

Comments

@d3r3kk
Copy link

d3r3kk commented Sep 12, 2018

DebuggerBanner won't open for the randomly selected users it is intended for, as it isn't set up for DI.

Environment data

  • VS Code version: 1.28.0-insider
  • Extension version (available under the Extensions sidebar): 2018.0
  • OS and version: Ubuntu 18.04
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Relevant/affected Python packages and their versions: n/a

Actual behavior

Users are not ever given the opportunity to provide feedback on the current debugging experience.

Expected behavior

Randomly selected users are given a popup that will direct them to a user survey (which they can dismiss if they aren't interested).

Steps to reproduce:

  1. Force becoming selected as a debugger feedback user.
  2. Debug the extension.
  3. In the debuggee, open the developer tools window and debug some code (can be super simple).
  4. End debugging session.

Logs

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285 [Extension Host] Python Extension: Error in debugger Banner Error: Missing required @injectable annotation in: Random.
	at getTargets (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:20:15)
	at Object.getDependencies (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:11:19)
	at /home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:106:51
	at Array.forEach (<anonymous>)
	at _createSubRequests (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:94:20)
	at Object.plan (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:129:9)
	at Container._planAndResolve (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:316:37)
	at Container._get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:309:44)
	at Container.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:228:21)
	at ServiceContainer.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/ioc/container.js:28:89)
	at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:126:55)
	at Generator.next (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
	at new Promise (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
	at DebuggerBanner.isUserSelected (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:117:16)
	at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:79:25)
	at Generator.next (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
	at new Promise (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
	at DebuggerBanner.shouldShow (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:72:16)
	at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:192:37)
	at Generator.next (<anonymous>)
	at fulfilled (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:15:58)
	at <anonymous> (at Logger.logError (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/common/logger.js:15:21))
t.log @ /usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285
/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2348 Formatter black is not installed. Install?
t.onDidNotificationChange @ /usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2348
/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285 [Extension Host] Python Extension: Error in debugger Banner Error: Missing required @injectable annotation in: Random.
	at getTargets (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:20:15)
	at Object.getDependencies (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/reflection_utils.js:11:19)
	at /home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:106:51
	at Array.forEach (<anonymous>)
	at _createSubRequests (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:94:20)
	at Object.plan (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/planning/planner.js:129:9)
	at Container._planAndResolve (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:316:37)
	at Container._get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:309:44)
	at Container.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/node_modules/inversify/lib/container/container.js:228:21)
	at ServiceContainer.get (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/ioc/container.js:28:89)
	at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:126:55)
	at Generator.next (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
	at new Promise (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
	at DebuggerBanner.isUserSelected (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:117:16)
	at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:79:25)
	at Generator.next (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:18:71)
	at new Promise (<anonymous>)
	at __awaiter (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:14:12)
	at DebuggerBanner.shouldShow (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:72:16)
	at DebuggerBanner.<anonymous> (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:192:37)
	at Generator.next (<anonymous>)
	at fulfilled (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/debugger/banner.js:15:58)
	at <anonymous> (at Logger.logError (/home/dekeeler/dev/github/d3r3kk/vscode-python/out/client/common/logger.js:15:21))
t.log @ /usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:285
@d3r3kk d3r3kk added needs PR bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Sep 12, 2018
@d3r3kk d3r3kk mentioned this issue Sep 12, 2018
Merged
6 tasks
This was referenced Sep 17, 2018
Closed
Closed
@DonJayamanne DonJayamanne reopened this Sep 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2018, week 36 - September 2018 Sprint 1
Development

Successfully merging a pull request may close this issue.

Fix problem preventing debugger user survey banner from appearing. d3r3kk/vscode-python
3 participants
@brettcannon @DonJayamanne @d3r3kk