Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: Common Utils - CacheUtils : Data is stored in cache and expired data is not returned #4776

Closed
d3r3kk opened this issue Mar 15, 2019 · 0 comments
Closed

Flaky test: Common Utils - CacheUtils : Data is stored in cache and expired data is not returned #4776

d3r3kk opened this issue Mar 15, 2019 · 0 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. macos

Comments

@d3r3kk
Copy link

d3r3kk commented Mar 15, 2019 •
edited
Loading

This test is failing on macOS:

https://github.com/Microsoft/vscode-python/blob/3cd69454e55fdc2bbe73fe0b585d689ff03808d1/src/test/common/utils/cacheUtils.unit.test.ts#L107

For the scenario of 'simple string' and 'undefined'.
Both are failing after only waiting for 50ms (they should make it until after 100ms).

Investigate (on Mac) and correct.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Mar 15, 2019
@d3r3kk d3r3kk added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. macos labels Mar 15, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Mar 15, 2019
d3r3kk pushed a commit to d3r3kk/vscode-python that referenced this issue Mar 21, 2019
Fix use of timers in a unit test scenario
0b86d02 
For microsoft#4776

- emulate passing of time for time-based testing
@d3r3kk d3r3kk mentioned this issue Mar 21, 2019
Merged
9 tasks
@ghost ghost removed the needs PR label Mar 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. macos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @d3r3kk