Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random functional test failure - Jupyter kernel shutdown is hanging tests #3544

Closed
rchiodo opened this issue Mar 27, 2019 · 2 comments
Closed
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Mar 27, 2019

Example:

‌ 1) Editor Context‌
(node:3724) UnhandledPromiseRejectionWarning: Error: Canceled
at KernelFutureHandler.dispose (D:\a\1\s\node_modules@jupyterlab\services\lib\kernel\future.js:150:31)
at _futures.forEach.future (D:\a\1\s\node_modules@jupyterlab\services\lib\kernel\default.js:875:20)
at Map.forEach ()
at DefaultKernel._clearState (D:\a\1\s\node_modules@jupyterlab\services\lib\kernel\default.js:874:23)
at DefaultKernel.dispose (D:\a\1\s\node_modules@jupyterlab\services\lib\kernel\default.js:336:14)
at DefaultSession.dispose (D:\a\1\s\node_modules@jupyterlab\services\lib\session\default.js:201:22)
at Promise (D:\a\1\s\out\client\common\utils\async.js:86:28)
at new Promise ()
at Object.callWithTimeout (D:\a\1\s\out\client\common\utils\async.js:81:12)
at JupyterSession. (D:\a\1\s\out\client\datascience\jupyter\jupyterSession.js:62:43)
at Generator.next ()
at fulfilled (D:\a\1\s\out\client\datascience\jupyter\jupyterSession.js:6:58)
at

THis is a part of jupyter session shutdown. Hard to repro and hard to get workaround.

@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 27, 2019

This is related:
jupyterlab/jupyterlab#4252

@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 27, 2019

Maybe skip if running a test? Don't need to shutdown the kernel necessarily. Or maybe wait longer than 100 ms to do the shutdown.

                    await Promise.race([this.session.shutdown(), sleep(100)]);

@rchiodo rchiodo self-assigned this Mar 27, 2019
rchiodo referenced this issue in microsoft/vscode-python Mar 28, 2019
For #4951, #4936

<!--
  If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.:
    - [x] ~Has unit tests & system/integration tests~
-->
- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
- [x] Title summarizes what is changing
- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)
- [ ] Has sufficient logging.
- [ ] Has telemetry for enhancements.
- [x] Unit tests & system/integration tests are added/updated
- [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate
- [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
- [ ] The wiki is updated with any design decisions/details.
@rchiodo rchiodo closed this as completed Apr 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant