Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review message displayed when minimum requirements are not met for LS support #5969

Closed
DonJayamanne opened this issue Jun 11, 2019 · 7 comments
Closed

Review message displayed when minimum requirements are not met for LS support #5969

DonJayamanne opened this issue Jun 11, 2019 · 7 comments
Assignees
@DonJayamanne @karrtikr
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality important Issue identified as high-priority
Milestone
2019 - July Sprin...

Comments

@DonJayamanne
Copy link

Current message displayed is as follows:

Screen Shot 2019-06-11 at 08 59 35

Feedback
Screen Shot 2019-06-11 at 08 55 51
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team needs decision important Issue identified as high-priority labels Jun 11, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 11, 2019
@DonJayamanne DonJayamanne added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality labels Jun 11, 2019
@DonJayamanne DonJayamanne added triage-needed Needs assignment to the proper sub-team and removed triage-needed Needs assignment to the proper sub-team labels Jun 11, 2019
@brettcannon brettcannon removed their assignment Jun 11, 2019
@brettcannon brettcannon added needs proposal Need to make some design decisions and removed needs decision labels Jun 26, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jun 26, 2019
@brettcannon brettcannon added this to the 2019 - June Sprint 13 milestone Jun 26, 2019
@luabud
Copy link
Member

luabud commented Jun 26, 2019 •
edited
Loading

In case users don't understand what is Jedi/why we're switching to it, can change message to:

Your operating system does not meet the minimum requirements of the Python Language Server. Reverting to the alternative autocompletion provider, Jedi.

And then more info could redirect to this instead: https://github.com/microsoft/python-language-server/blob/master/TROUBLESHOOTING.md#requirements

@luabud
Copy link
Member

luabud commented Jun 27, 2019

cc @qubitron

@brettcannon brettcannon removed the triage-needed Needs assignment to the proper sub-team label Jun 27, 2019
@qubitron
Copy link

Let's make it an aka.ms link so we can update the link if necessary if we have a better doc topic in the future.

@luabud
Copy link
Member

luabud commented Jun 27, 2019

https://aka.ms/pythonlsrequirements

@DonJayamanne DonJayamanne removed their assignment Jul 17, 2019
@luabud
Copy link
Member

luabud commented Jul 30, 2019

I believe we can change that to needs PR, can't we? @DonJayamanne

@brettcannon
Copy link
Member

@luabud if you believe the spec is done then please change the label.

@luabud luabud added needs PR and removed needs proposal Need to make some design decisions labels Jul 30, 2019
@DonJayamanne DonJayamanne self-assigned this Jul 31, 2019
@DonJayamanne DonJayamanne mentioned this issue Jul 31, 2019
Merged
3 tasks
@karrtikr
Copy link

karrtikr commented Aug 7, 2019

validated

@karrtikr karrtikr closed this as completed Aug 7, 2019
@ghost ghost removed the needs PR label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@karrtikr karrtikr

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Milestone
2019 - July Sprint 15
Development

No branches or pull requests
5 participants
@brettcannon @DonJayamanne @karrtikr @qubitron @luabud