Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test.ipynb from root directory into some other place for testing #3318

Closed
DonJayamanne opened this issue Jun 17, 2019 · 3 comments
Closed
Assignees

Comments

@DonJayamanne
Copy link
Contributor

Please can we move test related files into the src/tests folder.

@rchiodo
Copy link
Contributor

rchiodo commented Jun 18, 2019

The problem right now is the test that uses this is verifying that export doesn't add unnecessary cd commands when a file is in the root of the workspace. The root of the workspace is where the test.ipynb file is.

@IanMatthewHuff
Copy link
Member

It is really goofy there. Maybe put it in src/tests and move it out just for the actual test execution?

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jun 18, 2019

The root of the workspace is where the test.ipynb file is.

Currently when integration tests run, the cwd is tests directory...
If you need a custom cwd, we can change that on devops.

@rchiodo rchiodo self-assigned this Jun 28, 2019
@rchiodo rchiodo closed this as completed Aug 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants