Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user feedback when searching for a jupyter server to use and make it cancelable #3108

Closed
greazer opened this issue Sep 6, 2019 · 5 comments · Fixed by microsoft/vscode-python#7709
Assignees

Comments

@greazer
Copy link
Member

greazer commented Sep 6, 2019

If the user doesn't have a python interpreter selected, or the interpreter's environment doesn't have jupyter installed, we search. This search process can potentially take a long time.

We should notify that this situation is happening and that we're searching for a jupyter to use. One idea is to use the same notification style the AML extension uses, rather than a status message that people just don't see. In addition we can have a cancel button.

@DonJayamanne
Copy link
Contributor

We should notify that this situation is happening and that we're searching for a jupyter to use. One idea is to use the same notification style the AML extension uses

@rchiodo @ronglums @IanMatthewHuff Please could you advice on the message that needs to be displayed.

Here's the current message and the progress displayed.

  • I'm displaying the message Active interpreter does not support {0}. Searching for the best available interpreter. (where {0} will be one of the commands we check notebook, jupyter, etc.
  • As part of the progress I display the name of the interpreter thats being checked.

You can see this in the blow animated Gif (added a forced delay so that the messages appear and you can see them).

Forced delays
progress

No delays (actual speed)
Note: You'll see two messages that because I've forced the display of the messages
progressFast

@rchiodo
Copy link
Contributor

rchiodo commented Oct 1, 2019

Looks good to me. Are you saying it's too fast?

@DonJayamanne
Copy link
Contributor

Looks good to me. Are you saying it's too fast?

No, added a slower version so one could see the exact contents of the progress message.

@rchiodo rchiodo self-assigned this Oct 9, 2019
@rchiodo
Copy link
Contributor

rchiodo commented Oct 9, 2019

Validated, but the UI feels weird. My expectation is that the dialog will stay open until the server starts. I'm going to enter a separate issue for that.

@DonJayamanne
Copy link
Contributor

I'm going to enter a separate issue for that.

Agreed.

@rchiodo rchiodo closed this as completed Oct 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants