Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus not set to newly added cell #2971

Closed
DonJayamanne opened this issue Oct 8, 2019 · 4 comments
Closed

Focus not set to newly added cell #2971

DonJayamanne opened this issue Oct 8, 2019 · 4 comments
Assignees

Comments

@DonJayamanne
Copy link
Contributor

In master branch:

  • Open a native editor with 3 cells
  • Select the first cell and confirm it is selected
  • Set focus to the first cell and confirm focus is set
  • Now, click the + sign on the Toolbar
  • Confirm a new cell has been added and it is focused
  • Next set focus to the last cell
  • Now click the + sign on the toolbar
  • Confirm a new cell has been added to the bottom
    Bug: The newly added cell is not focused

You can replicate the same issue as follows:

  • Set focus to the last cell
  • Click the + sign at the bottom of the native editor
  • Confirm a new cell has been added to the bottom
    Bug: The newly added cell is not focused
@rchiodo rchiodo self-assigned this Oct 8, 2019
@rchiodo
Copy link
Contributor

rchiodo commented Oct 8, 2019

I swear I fixed this yesterday. I need more sleep I guess.

@IanMatthewHuff IanMatthewHuff self-assigned this Oct 9, 2019
@IanMatthewHuff
Copy link
Member

This is not validated for one scenario.

If you set focus to the last cell and then use the + button on the top toolbar the new cell is added but focus is not set to it. Note this is only on the last cell and only with the toolbar button (the add cell line works).

@IanMatthewHuff IanMatthewHuff removed their assignment Oct 9, 2019
@rchiodo
Copy link
Contributor

rchiodo commented Oct 9, 2019

Damn, I forgot the toolbar button.

@IanMatthewHuff IanMatthewHuff self-assigned this Oct 21, 2019
@IanMatthewHuff
Copy link
Member

Validated that the scenario that I previously was still seeing is now fixed.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants