Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use asWebviewUri to generate URI for use in webview #2955

Closed
DonJayamanne opened this issue Oct 9, 2019 · 1 comment
Closed

Use asWebviewUri to generate URI for use in webview #2955

DonJayamanne opened this issue Oct 9, 2019 · 1 comment
Assignees
@DonJayamanne

Comments

@DonJayamanne
Copy link
Contributor

Currently we have hardcoded the value vscode-resource as the resource.
In the latest VS Code api, this is discouraged (logged as a warning in extension logs) and the use of asWebviewUri is recommended.
@DonJayamanne DonJayamanne self-assigned this Oct 9, 2019
@rchiodo
Copy link
Contributor

rchiodo commented Oct 14, 2019

Validated

@rchiodo rchiodo closed this as completed Oct 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @rchiodo