Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Esc does not cancel debugging #8626

Closed
kzhui125 opened this issue Nov 16, 2019 · 4 comments
Closed

Pressing Esc does not cancel debugging #8626

kzhui125 opened this issue Nov 16, 2019 · 4 comments
Assignees
@karrtikr @kimadeline
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Milestone
2020 January Sprint

Comments

@kzhui125
Copy link

  1. Debug - Start Debugging

屏幕快照 2019-11-16 下午4 55 18

  1. press ESC to cancel

But python debugging will be started.
@kzhui125 kzhui125 added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Nov 16, 2019
@karthiknadig karthiknadig added triage and removed triage-needed Needs assignment to the proper sub-team labels Nov 18, 2019
@karrtikr karrtikr mentioned this issue Nov 18, 2019
Closed
@karrtikr
Copy link

karrtikr commented Nov 18, 2019 •
edited
Loading

Closing in favor of microsoft/vscode#85078

@ghost ghost removed the triage label Nov 18, 2019
@karrtikr karrtikr reopened this Nov 19, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Nov 19, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Nov 19, 2019
@karrtikr
Copy link

karrtikr commented Nov 19, 2019 •
edited
Loading

Turns out it is an extension issue.

The issue seems to be that the resolveDebugConfiguration of the python extension opens the quickPick. The quickPick is cancelled by the user, and the resolveDebugConfiguration should return undefined. However the resolveDebugConfiguration does not return undefined it returns the config object and VS Code happily continues with debugging.

Prescribed solution

Return undefined when no quick pick option is selected.

@karrtikr karrtikr removed their assignment Nov 19, 2019
@karrtikr karrtikr changed the title can't press ESC to cancel debug Pressing Esc does not cancel debugging Nov 19, 2019
@luabud
Copy link
Member

luabud commented Jan 15, 2020 •
edited
Loading

Create issue to add UI tests for this in the future, but add this to the test plan for now.

@luabud luabud added this to the 2020 January Sprint milestone Jan 22, 2020
@karrtikr karrtikr self-assigned this Jan 23, 2020
@karrtikr karrtikr mentioned this issue Jan 23, 2020
Merged
10 tasks
@kimadeline kimadeline self-assigned this Jan 30, 2020
@kimadeline
Copy link

✅ Validated in 2020.2.60336-dev.

@ghost ghost removed the needs PR label Jan 30, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

@kimadeline kimadeline

Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
2020 January Sprint
Development

No branches or pull requests
5 participants
@karthiknadig @kzhui125 @karrtikr @luabud @kimadeline