Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content is getting overlapped in notebook toolbar #2551

Closed
DonJayamanne opened this issue Dec 16, 2019 · 14 comments
Closed

Content is getting overlapped in notebook toolbar #2551

DonJayamanne opened this issue Dec 16, 2019 · 14 comments
Assignees

Comments

@DonJayamanne
Copy link
Contributor

The text on the right (remote url and kernel info) is not getting wrapped.

Screen Shot 2019-12-16 at 12 24 18
Screen Shot 2019-12-16 at 12 24 29

@greazer
Copy link
Member

greazer commented Dec 17, 2019

Probably the same, but just in case:
image

@rchiodo
Copy link
Contributor

rchiodo commented Dec 18, 2019

The first picture was on purpose as it didn't seem necessary for this release. The wrap to the next line was not however.

@DonJayamanne
Copy link
Contributor Author

The wrap to the next line was not however.

Wasn't this identified and fixed in a separate issue?

@DavidKutu DavidKutu self-assigned this Jan 7, 2020
@DavidKutu
Copy link

image
is this ok?

@rchiodo
Copy link
Contributor

rchiodo commented Jan 7, 2020

No I think it should slowly shrink over time. Wrapping to the next line seems off to me.

@IanMatthewHuff
Copy link
Member

I'm not 100% sure what Rich was meaning by "shrink". But I think that I would have it all squish down until it uses the minimum space possible in one line like so:
image
Then if it gets any smaller you would just lose text starting from the right side.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 7, 2020

That's pretty much what I meant, except it would lose text from the URI and then the kernel name at the same rate.

@DonJayamanne
Copy link
Contributor Author

I think we should just use a style to hide overflow with .... If velow a certain width we can just hard code to display a content of ... or hide the icons all together. E.g. what if we don't have space to even display ... (I think just hide in that case).

To me a more bullet proof solution is to overflow the icons into an overflow menu where user would have to click ... that would display the collapsed items.

@DavidKutu
Copy link

image

How about this? The toolbar turns into 2 lines if there's no space.

The thing is, if stuff shrinks, its gonna be hard to click. And if we loose text from the status bar then eventually it becomes useless as the status is not visible. If we do this, everything stays visible and clickable.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 8, 2020

I still think we can't have two lines. Maybe it minimizes down to just the icon at some point. Then the icon can be clicked to change.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 8, 2020

@ronglums @jmew what do you guys think?

@DonJayamanne
Copy link
Contributor Author

I still think we can't have two lines

I agree, we should just reduce the size or collapse completely (i.e. hide) instead of taking vertical room.

@jmew
Copy link
Contributor

jmew commented Jan 9, 2020

I like the overflow "..." menu idea for the icons, i think that design is intuitive and follows the practice of basic design principles.

@IanMatthewHuff IanMatthewHuff self-assigned this Jan 16, 2020
@IanMatthewHuff
Copy link
Member

Validated, no overlap anymore, but it does push down to two lines.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants