Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems Rendering HeroCards after issue #4249 #4362

Closed
rchardin opened this issue Oct 11, 2021 · 9 comments
Closed

Problems Rendering HeroCards after issue #4249 #4362

rchardin opened this issue Oct 11, 2021 · 9 comments
Assignees
Labels
needs-author-feedback Needs more info from the customer. status-no-recent-activity teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label

Comments

@rchardin
Copy link

rchardin commented Oct 11, 2021

Ever since receiving the error described in issue #4249, tables that were rendering fine and continue to render fine on the web based client are seeing the first column become squished.
Good:
image
Bad:
image
Code:

`            var rcard = new HeroCard();
            rcard.Title = $"Welcome {turnContext.Activity.From.Name}";
            rcard.Text = $"<table table-layout: \"auto\">" +
                $"<tr>" +
                $"<th style=\"text-align:center\">Command</th>" +
                $"<th style=\"text-align:center\">Function</th>" +
                $"</tr>" +
                $"<tr><td>!r</td><td>Make a new lab request</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!</td><td>List of previous requests</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>| Text |</td><td>If you are not in conversation, type your question and it will be logged in as a free form request and answered on a first come first served basis.</td></tr>" +
                $"<tr><td><br/></td></tr></table>" +
                $"<hr><table table-layout: \"auto\">" +
                $"<tr>" +
                $"<th style=\"text-align:center\">Command</th>" +
                $"<th style=\"text-align:center\">Function</th>" +
                $"</tr>" +
                $"<tr><td>!who</td><td>List of current conversations and the person with whom you are conversing. Allows user to select another conversation. (Used by Techs)</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!punt</td><td>Return an accepted job to the queue, preferably to @mention another tech to continue request. (Used by Techs)</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!group</td><td>Move this request to the web based group queue.  This effectively closes the job within this tool but transfers all information to group tool.(Used by Techs)</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!greet:</td><td>Everything following the colon (:) will become your new greeting when you accept a job. (Used by Techs) </td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!exit</td><td>Exit the current conversation.  If you have other conversations open, the next will be made active. (Used by Techs)</td></tr></table>";
            rcard.Buttons = new List<CardAction>() { };

            rcard.Buttons.Add(new CardAction
            {
                Type = ActionTypes.OpenUrl,
                Title = "Watch Video",
                Value = "https://bobscupofsoup.com/Help.mp4?csf=1&web=1&e=U3dbqf"
            });`
@ghost
Copy link

ghost commented Oct 11, 2021

Hi rchardin! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@ghost ghost added the needs-triage 🔍 label Oct 11, 2021
@ghost ghost added the teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label label Oct 11, 2021
@HunaidHanfee-MSFT
Copy link

We are looking into this, will get back to you soon.
Thanks

@HunaidHanfee-MSFT
Copy link

I am able to repro the issue at my end. I need confirm internally about this behavior. I will get back to you with findings.

Thanks

@HunaidHanfee-MSFT
Copy link

We have raised a bug, I don't have an ETA to share but I will keep you updated about the status.

Thanks

@rchardin
Copy link
Author

Thankyou @HunaidHanfee-MSFT. Please let me know where would be the best place to track.

@HunaidHanfee-MSFT
Copy link

Sorry, the bug is internal and it's not publicly accessible. I will keep you updated about fix.

Thanks

@rchardin
Copy link
Author

rchardin commented Nov 2, 2021

Workaround found:

rcard.Text = $"<table style=\"width: 100 % \">" +
                $" <colgroup>" +
                $"<col span = \"1\" style = \"width: 22%;\">" +
                $"<col span = \"1\" style = \"width: 78%;\">" +
                $"</colgroup>" +
                $"<tbody>" +
                $"<tr>" +
                $"<th style=\"text-align:center\">Command</th>" +
                $"<th style=\"text-align:center\">Function</th>" +
                $"</tr>" +
                $"<tr><td>!r</td><td>Make a new lab request</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!</td><td>List of previous requests</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>| Text |</td><td>If you are not in conversation, type your question and it will be logged in as a free form request and answered on a first come first served basis.</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!cancel</td><td>Cancel current request.</td></tr>" +
                $"</tbody></table>" +
                $"<hr><table>" +
                $"<colgroup>" +
                $"<col span = \"1\" style = \"width: 22%;\">" +
                $"<col span = \"1\" style = \"width: 78%;\">" +
                $"</colgroup>" +
                $"<tbody>" +
                $"<tr>" +
                $"<th style=\"text-align:center\">Command</th>" +
                $"<th style=\"text-align:center\">Function</th>" +
                $"</tr>" +
                $"<tr><td>!who</td><td>List of current conversations and the person with whom you are conversing. Allows user to select another conversation. (Used by Techs)</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!punt</td><td>Return an accepted job to the queue, preferably to @mention another tech to continue request. (Used by Techs)</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!group</td><td>Move this request to the web based group queue.  This effectively closes the job within this tool but transfers all information to group tool.(Used by Techs)</td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!greet:</td><td>Everything following the colon (:) will become your new greeting when you accept a job. (Used by Techs) </td></tr>" +
                $"<tr><td><br/></td></tr>" +
                $"<tr><td>!exit</td><td>Exit the current conversation.  If you have other conversations open, the next will be made active. (Used by Techs)</td></tr></tbody></table>";

@ChetanSharma-msft
Copy link
Collaborator

@rchardin - Looks like your issue has resolved, shall we close the bug?

@ChetanSharma-msft ChetanSharma-msft added the needs-author-feedback Needs more info from the customer. label Jan 25, 2022
@ghost
Copy link

ghost commented Jan 28, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Jan 31, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-author-feedback Needs more info from the customer. status-no-recent-activity teams-developer-support Question related to extensibility (Bot, ME, Tab) would be marked under this label
Projects
None yet
Development

No branches or pull requests

4 participants