Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-buttons-usb-encoder.sh broken after commit 3d7c7cf #1318

Closed
derchan opened this issue Feb 27, 2021 · 4 comments · Fixed by #1323
Closed

setup-buttons-usb-encoder.sh broken after commit 3d7c7cf #1318

derchan opened this issue Feb 27, 2021 · 4 comments · Fixed by #1323

Comments

@derchan
Copy link
Contributor

derchan commented Feb 27, 2021

Hi,

the setup of the buttons usb encoder broke last week in the development branch. I was able to pin it down to one commit 3d7c7cf
On previous commit the installer seems to work fine.

git diff 91dc192..3d7c7cf -- ./components

~/RPi-Jukebox-RFID $ git checkout 3d7c7cf ./components
~/RPi-Jukebox-RFID $ git clean -fd components/
sudo components/controls/buttons_usb_encoder/setup-buttons-usb-encoder.sh

Than is no mapping possible following message appears:

During the next step you can map your buttons to one of the following available functions:
[]

Ready to continue? (y/n)

@s-martin
Copy link
Collaborator

gpio_control was refactored to a class.
This needs to be considered here


and here
import components.gpio_control.function_calls

@arne123 could you have a look?

@arne123
Copy link
Collaborator

arne123 commented Feb 28, 2021

I Just had a look,
is my understanding correct, that either the USB Buttons or the GPIO Control are used?
The common point are just the function calls?

@s-martin
Copy link
Collaborator

Yes and yes :)

@s-martin
Copy link
Collaborator

s-martin commented Mar 7, 2021

PR #1323 is merged, issue should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants