Install Script not Parsing Spotify Password into mopidy.conf correctly

[Jdiesel87]

I have confirmed this with both the master and develop releases.

When you enter your Spotify credentials during the install script it results in a mopify login error. When viewing the mopidy.conf the spotify password field has incorrectly inserted "spotify_password" into the center of the correct password text. It must be edited in the config manually to authenticate with Spotify.

[s-martin]

this should happen here:

RPi-Jukebox-RFID/scripts/installscripts/buster-install-default.sh

Lines 923 to 948 in be6bc67

	if [ "${SPOTinstall}" == "YES" ]; then
	local etc_mopidy_conf="/etc/mopidy/mopidy.conf"
	local mopidy_conf="${HOME_DIR}/.config/mopidy/mopidy.conf"
	echo "Configuring Spotify support..."
	sudo systemctl disable mpd
	sudo systemctl enable mopidy
	# Install Config Files
	sudo cp "${jukebox_dir}"/misc/sampleconfigs/locale.gen.sample /etc/locale.gen
	sudo cp "${jukebox_dir}"/misc/sampleconfigs/locale.sample /etc/default/locale
	sudo locale-gen
	mkdir -p "${HOME_DIR}"/.config/mopidy
	sudo cp "${jukebox_dir}"/misc/sampleconfigs/mopidy-etc.sample "${etc_mopidy_conf}"
	cp "${jukebox_dir}"/misc/sampleconfigs/mopidy.sample "${mopidy_conf}"
	# Change vars to match install config
	sudo sed -i 's/%spotify_username%/'"$SPOTIuser"'/' "${etc_mopidy_conf}"
	sudo sed -i 's/%spotify_password%/'"$SPOTIpass"'/' "${etc_mopidy_conf}"
	sudo sed -i 's/%spotify_client_id%/'"$SPOTIclientid"'/' "${etc_mopidy_conf}"
	sudo sed -i 's/%spotify_client_secret%/'"$SPOTIclientsecret"'/' "${etc_mopidy_conf}"
	# for $DIRaudioFolders using | as alternate regex delimiter because of the folder path slash
	sudo sed -i 's|%DIRaudioFolders%|'"$DIRaudioFolders"'|' "${etc_mopidy_conf}"
	sed -i 's/%spotify_username%/'"$SPOTIuser"'/' "${mopidy_conf}"
	sed -i 's/%spotify_password%/'"$SPOTIpass"'/' "${mopidy_conf}"
	sed -i 's/%spotify_client_id%/'"$SPOTIclientid"'/' "${mopidy_conf}"
	sed -i 's/%spotify_client_secret%/'"$SPOTIclientsecret"'/' "${mopidy_conf}"
	# for $DIRaudioFolders using | as alternate regex delimiter because of the folder path slash
	sudo sed -i 's|%DIRaudioFolders%|'"$DIRaudioFolders"'|' "${mopidy_conf}"

by just looking at it I can’t see an obvious problem.

[UbiGIT89]

Same issue with my config.

For me it seems that the trigger is a dollar sign ($) in the password.
The "$" and the next character are missing in the mopidy.conf and have to be added manually.

It doesn't matter if I ran automated or interactiv installation.

[Jdiesel87]

There is know $ in my password but I do have a & if that helps with troubleshooting. I haven't had a chance to rerun the installer script to see exactly what is happening yet.

[AlvinSchiller]

This will be fixes with #2315

[kingosticks]

Did you identify the issue and is there a fix somewhere for this in #2315 ? To me,

RPi-Jukebox-RFID/scripts/installscripts/install-jukebox.sh

Line 631 in 33baf83

echo "SPOTIpass=\"$SPOTIpass\"";

looks like the problem when the value contains a dollar sign (or double-quotes, maybe other special characters too). I can't see a fix for it so I had a go. Apologies if there was already something in place, in which case please disregard all this!

e.g.

> mypass='hello$world'
> echo mypass
hello$world
> echo "SPOTIpass=\"$mypass\"" > test.conf && source test.conf && echo $SPOTIpass
hello
> cat test.conf
SPOTIpass="hello$world"

You lose everything after the dollar because the double quotes inserted into test.conf tell bash to interpolate the variable $world (which is empty in this case). Using single quotes would avoid this and still prevent unwanted word-splitting e.g.

> echo "SPOTIpass='$mypass'" > test.conf && source test.conf && echo $SPOTIpass
hello$world
> cat test.conf
SPOTIpass='hello$world'

But you'd still have a problem with any quote characters in there:

> mypass="hello'world"
> echo mypass
hello'world
> echo "SPOTIpass='$mypass'" > test.conf && source test.conf && echo $SPOTIpass
bash: ./test.conf: line 1: unexpected EOF while looking for matching `''
bash: ./test.conf: line 2: syntax error: unexpected end of file
> cat test.conf
SPOTIpass='hello'world'

They need to be escaped. And maybe also consider switching to the bash literal syntax ($'mystring'). The following seems more robust and hopefully not much more painful to read/comprehend:

# Helper function to escape single quotes by prefixing them them with a slash.
> esq() { printf "%s" ${1//\'/\\\'}; }
> mypass="hello'world\$again"
> echo mypass
hello'world$again
> echo $(esq $mypass)
hello\'world$again
> echo "SPOTIpass=\$'$(esq $mypass)'" > test.conf && source test.conf && echo $SPOTIpass
hello'world$again
> cat test.conf
SPOTIpass=$'hello\'world$again'

You'd need to do this everywhere the user's input might contain problematic characters (i.e. not just the Spotify password).

[kingosticks]

haha, you have a fix now. I shouldn't have gone for lunch before submitting that!