-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 | Single file play (#682) doesn't work with filenames containing ' and append file to playlist ( #785) doesn't work at all #982
Comments
So what happens, when you try to play the file? Nothig or an error? Could you also post the results of |
There is no reaction / no error. |
Probably not directly related to the problem, but you have a lot of errors like
Do you use an RFID reader or do you intend to use one? If you don’t intend to use one you could disable the service with
|
No, it's my rpi to test. No reader installed. |
I guess it’s a web interface issue, so I asked for the wrong log, sorry. Could you post the output of |
There is no error related to pressing "add" or "single file play" |
Could you manually check, if your issue is fixed, if you manually apply the change in #993? |
Yes, these errors are gone! |
So ist the behavior also gone or just the warnings in the log file? I can't reproduce, because I don't have a working Pi right now. |
No, the behaviour is the same. Just the warnings are gone. |
Mental note: investigate escaping single and double quotes for mpd / mpc String values are quoted with single or double quotes, and special characters within those values must be escaped with the backslash (). Keep in mind that the backslash is also the escape character on the protocol level, which means you may need to use double backslash. |
OK. Two changes are necessary:
The single file play is working for me now. But i'll go to bed now. I will open a pullrequest soon. |
I also looked into making it possible to use single quotes in folder names, but there are also problems with creating folders in webinterface containing other special characters like double quotes or $ I don't think it's worth the efforts. Better to advice users to not use special characters in foldernames. |
Bug
What I did
I tried to play a single file.
What happened
Most files play fine, but files with ' in filename don't. (eg. "Alle Leut'" or "Ein Schneider fing 'ne Maus"
I expected this to happen
It works for all files.
Further information that might help
There is no information in syslog and debug.log (I enabled debugging for Webapp_API and playoutcontrols.
Software
Base image and version
Raspian Buster Lite
Branch / Release
latest develop - classic
Installscript
buster-install-default
Hardware
RaspberryPi version
3B
RFID Reader
None
Soundcard
PCM
Other notable hardware
None
The text was updated successfully, but these errors were encountered: