Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are .jshintrc files above the project loaded? #142

Open
bobrocke opened this issue Jun 10, 2015 · 5 comments
Open

Are .jshintrc files above the project loaded? #142

bobrocke opened this issue Jun 10, 2015 · 5 comments

Comments

@bobrocke
Copy link

If my .jshintrc file is in my user directory, will the interactive linter load it from there, or must it be in the project folder?

@MiguelCastillo
Copy link
Owner

@bobrocke sorry I haven't responded to your other issues/enhancement requests. Been swamped. But the answer this is no, interactive linter stops looking right the project directory. The proper use would be to open the directory with the .jshintrc, which is where you probably have other config files.

@bobrocke
Copy link
Author

Would you consider adding the ability to search up though the folder hierarchy until a .jshintrc is found and use that? It would make it much easier, as that is the default for many other tools, and allows an individual to have a common standard, but then to modify that standard on projects that require differences.

@MiguelCastillo
Copy link
Owner

@bobrocke This would be going against the "project" based approach in brackets. But while I am not really opposed to it, I would want to test it for a bit before committing to adding this functionality. Would you be interested in submitting a PR?

@bobrocke
Copy link
Author

I have looked at your code. Is this something another person could work through?

@MiguelCastillo
Copy link
Owner

@bobrocke if you would like to play with the idea, this is the line you need to change. Remove filePath.indexOf(currentProject.fullPath) === -1 from the conditional.

Let me know if that works for you. Perhaps I will try it as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants