Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-12: Mock & Spy on inner class is broken #12

Closed
MikeSchulze opened this issue Oct 22, 2022 · 0 comments · Fixed by #41
Closed

GD-12: Mock & Spy on inner class is broken #12

MikeSchulze opened this issue Oct 22, 2022 · 0 comments · Fixed by #41
Assignees
@MikeSchulze
Labels
bug Something isn't working godot related issue Its a bug by Godot engine and can't be fixed by GdUnit

Comments

@MikeSchulze
Copy link
Owner

MikeSchulze commented Oct 22, 2022 •
edited
Loading

The used Godot version:
v4.0.beta3.official [01ae26d31]

OS including version:
ALL

Describe the bug
Mocking inner classes is broken in Godot4

Steps to Reproduce
run res://addons/gdUnit4/test/mocker/GdUnitMockerTest.gd
test cases:
test_mock_class_with_inner_classs
test_mock_verify_emit_signal

res://addons/gdUnit4/test/spy/GdUnitSpyTest.gd : _test_spy_on_inner_class
res://addons/gdUnit4/test/cmd/CmdCommandHandlerTest.gd : test_execute_commands_with_cb_registered

workaround

n.a.
the tests are commented out, must be reactivated when the bug is fixed

Godot issue

godotengine/godot#67753
@MikeSchulze MikeSchulze added bug Something isn't working godot related issue Its a bug by Godot engine and can't be fixed by GdUnit labels Oct 22, 2022
@MikeSchulze MikeSchulze self-assigned this Oct 22, 2022
@MikeSchulze MikeSchulze changed the title Mock inner a class is broken Mock & Spy on inner class is broken Oct 24, 2022
@MikeSchulze MikeSchulze changed the title Mock & Spy on inner class is broken GD-12: Mock & Spy on inner class is broken Nov 5, 2022
@FeralBytes FeralBytes mentioned this issue Nov 12, 2022
Closed
@MikeSchulze MikeSchulze linked a pull request Nov 17, 2022 that will close this issue
GD-12: Reenable tests where was temporary disabled #41
Merged
@MikeSchulze MikeSchulze moved this to Done in GdUnit4 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
bug Something isn't working godot related issue Its a bug by Godot engine and can't be fixed by GdUnit
Projects
GdUnit4
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GD-12: Reenable tests where was temporary disabled MikeSchulze/gdUnit4
1 participant
@MikeSchulze