Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-32: Create test case should use configured text ident settings #32

Closed
FeralBytes opened this issue Nov 12, 2022 · 0 comments · Fixed by #35
Closed

GD-32: Create test case should use configured text ident settings #32

FeralBytes opened this issue Nov 12, 2022 · 0 comments · Fixed by #35
Assignees
Labels
bug Something isn't working minor
Milestone

Comments

@FeralBytes
Copy link

FeralBytes commented Nov 12, 2022

No Duplicates.

The used Godot version:
v4.0.beta4.official [e6751549c] Vulkan AKA Forward+

OS including version:
OS: Linux Mint 20.3 Cinnamon 5.2.7
Kernel: 5.4.0-131-generic
CPU: AMD Ryzen 9 3900X 12-Core Processor × 12
GPU: Advanced Micro Devices, Inc. [AMD/ATI] Navi 10 [Radeon RX 5700 XT]

Describe the bug
Specific Error from Godot:

res://test/SettingsTest.gd:18 - Parse Error: Used tab character for indentation instead of space as used before in the file.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Click on Editor
  2. Click on Editor Settings
  3. Click on Text Editor -> Behavior
  4. Set Indent Type to Spaces
  5. Set Convert Indent on Save to On.
  6. Install GDUnit4
  7. Ensure GDUnit4 is enabled in plugins in case of crash.
  8. Build a test file in the test directory as GDUnit4 does not yet have this capability.
  9. Right click on a function in the GDScript file for the corresponding test file that you created and choose Create Test.
  10. Observer the errors below in the output panel.

Minimal reproduction project:
GDUnit4NullReturnIssue.zip

Note:
This is also an issue for GDUnit3 but it does not fail in Godot 3.

@FeralBytes FeralBytes added the bug Something isn't working label Nov 12, 2022
@MikeSchulze MikeSchulze changed the title Respect User Choice to use Spaces versus Tabs or Will not work in Godot 4.0 GD-32: Respect User Choice to use Spaces versus Tabs or Will not work in Godot 4.0 Nov 13, 2022
@MikeSchulze MikeSchulze added this to the V4.0.1 milestone Nov 13, 2022
@MikeSchulze MikeSchulze changed the title GD-32: Respect User Choice to use Spaces versus Tabs or Will not work in Godot 4.0 GD-32: Create test case should use configured text ident settings Nov 13, 2022
@MikeSchulze MikeSchulze linked a pull request Nov 13, 2022 that will close this issue
@MikeSchulze MikeSchulze moved this to Done in GdUnit4 Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants