Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-609: Change the default update notification mechanism to a less intrusive one #609

Closed
taikuukaits opened this issue Dec 8, 2024 · 2 comments · Fixed by #612
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@taikuukaits
Copy link

Is your feature request related to a problem? Please describe.
I think the default approach of the update notification popup should be replaced with a new mechanism that is less intrusive. Currently I just turn it off in every project and then I lose information about new updates.

The update popup can be intrusive and get in the way of a normal workflow:

  • it's not immediate so it becomes a waiting game to see if I will be interrupted
  • sometimes I can't even close the popup until it finishes loading.
  • most of the time I don't even want to update right now, I opened the game to do something else not update gdunit, but I might later

I also don't believe this solution scales. If I had four assets in this project, each using this same approach, it would be even worse. I would get up to four popups whenever I open my project, each telling me about possible updates right away before I am even in my project. This seems undesirable.

Describe the solution you'd like
I would recommend a few changes:

  • Do not show the current popup when opening a project.
  • Print a message to the log instead on project load "A new version of GDUnit is available".
  • If an update is available, add a button on the GdUnit inspector beneath Errors and Failures "An update is available. Learn more." that I can click on that opens the current popup.

The log and button should respect the update notification setting.

Describe alternatives you've considered

I know I can skip an individual update in the popup but there seem to be constant releases (which I do appreciate) but that does mean I constantly get this popup even if I select skip this update. It still at least seems like I get a full page popup every time I open my game if I leave the popup on.

I know I can turn off this popup altogether, but I do like being notified that there are updates and I do like clicking a button to get new update installed automatically.

Additional context
I would be willing to take a crack at implementing this if this is something that would be accepted.

@taikuukaits taikuukaits added the enhancement New feature or request label Dec 8, 2024
@taikuukaits taikuukaits changed the title Change the default update notification mechanism to a less intrusive one GD-606: Change the default update notification mechanism to a less intrusive one Dec 8, 2024
@taikuukaits taikuukaits changed the title GD-606: Change the default update notification mechanism to a less intrusive one GD-609: Change the default update notification mechanism to a less intrusive one Dec 8, 2024
@MikeSchulze
Copy link
Owner

I understand your problem and yes it does make sense to design the update notification differently.
Thanks for the hint, I will think of a solution that does not use a popup to indicate a new update.

@MikeSchulze MikeSchulze added this to the 4.4.4 milestone Dec 8, 2024
@MikeSchulze
Copy link
Owner

MikeSchulze commented Dec 9, 2024

I suggest an update notification inside the inspector.
You can press, and the original update window will pop up.
notification_inspector

Alternative, I can change the console status for gdunit
notification_console

@MikeSchulze MikeSchulze linked a pull request Dec 11, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this to Done in GdUnit4 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants