Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Indirect Proxy Mode: If one panel fails to render the previous gets duplicated #128

Closed
friesoft opened this issue Mar 12, 2018 · 9 comments
Assignees

Comments

@friesoft
Copy link
Contributor

Using indirect proxy mode the first panel is duplicated if the second fails to render.

Expected Behavior

Show error message about failing to fetch the second panel like in proxy mode

Current Behavior

Duplicate first panel

Steps to Reproduce (for bugs)

  1. Create dashboard with 2 panels (second one should fail to render)
  2. Assign dashboard to service
  3. Use proxy mode to verify the second panel can't be displayed
  4. Switch to indirect proxy mode => duplicate first panel

Your Environment

  • Icinga Web 2 Grafana version (System - About): master (126fd9b)
  • Icinga Web 2 version and modules (System - About): 2.5.1
  • Grafana Version: 5.0 pre
  • Version used (icinga2 --version): 2.8.1-1
  • Operating System and version: Red Hat 7.4
@friesoft
Copy link
Contributor Author

PS: thanks for the indirect proxy mode! 😃 much faster! 👍

@Mikesch-mp
Copy link
Owner

Mikesch-mp commented Mar 12, 2018

Can you upload dashboard and post module config + graph config please

And please update Grafana to 5.0 or 5.0.1. pre releases are known to have a lot of bugs (see my module 😄 )

@friesoft
Copy link
Contributor Author

I'll post the dashboard/config tomorrow (battery of my notebook just died)

I'll also try to update Grafana tomorrow. Last time I tried the beta I experienced some (reported) bugs preventing the move to production.

Thanks for the fast response :)

@friesoft
Copy link
Contributor Author

5.0.1 doesn't work for me yet as I hit this bug: grafana/grafana#11180

module config:

[grafana]
host = "ourip:3000"
protocol = "http"
defaultdashboard = "icinga2-influxdb-default"
defaultorgid = "1"
defaultdashboardstore = "db"
theme = "light"
datasource = "influxdb"
accessmode = "indirectproxy"
height = "280"
width = "900"
enableLink = "yes"
usepublic = "yes"
publichost = "ourdomain/grafana"
publicprotocol = "https"
debug = "0"
timerangeAll = "1w/w"
shadows = "1"
authentication = "token"
apitoken = "ourtoken"
custvardisable = "grafana_graph_disable"
custvarconfig = "grafana_graph_config"
defaultdashboardpanelid = "1"

graph config

[Loadbalancing]
dashboard = "icinga2-loadbalancing"
panelId = "1,2"
orgId = "1"
height = "150"
repeatable = "no"

Dashboard: icinga2_loadbalancing.txt

@juangranados
Copy link

Same problem on Grafana 5.0.1 as explained in #129

@Mikesch-mp
Copy link
Owner

Mikesch-mp commented Mar 13, 2018

Yeah, PanelIDs start at 2 with Grafana 5. Set you panelId to 2,3 and everything should be ok. to make it sure check the panelIds in Grafana. If this doesnt help, export and re import your dashboard if it is created with Grafana 4.x

@Mikesch-mp
Copy link
Owner

Seem a bug with reverse proxy and panelid 1 . Just checked my setup (without reverse proxy) and it works flawless.

@Mikesch-mp
Copy link
Owner

@friesoft Can you please test the latest master? i just pushed a fix for repeating panels that also fixes multiple ids configured.

@friesoft
Copy link
Contributor Author

Works great now 😃 Thanks for the lightning fast fix! 🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants