Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] input rules in inlineCode should keep code. #622

Closed
4-1-1 opened this issue Jul 21, 2022 · 7 comments
Closed

[Bug] input rules in inlineCode should keep code. #622

4-1-1 opened this issue Jul 21, 2022 · 7 comments
Assignees
Labels
bug Something isn't working planned This issue is being planned in iteration

Comments

@4-1-1
Copy link

4-1-1 commented Jul 21, 2022

Describe the bug

All punctuation in an inline code should be reserved.
To Reproduce
Steps to reproduce the behavior:

input `*a*`
got a bold in an inline code.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

Milkdown version
List the versions of milkdown packages you have here.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [chrome]
  • Version [6.3]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@4-1-1 4-1-1 added the bug Something isn't working label Jul 21, 2022
@Saul-Mirone
Copy link
Member

Saul-Mirone commented Jul 21, 2022

I can't reproduce this. Can you please provide more details or upload a video?

@Saul-Mirone Saul-Mirone added the invalid This doesn't seem right label Jul 21, 2022
@4-1-1
Copy link
Author

4-1-1 commented Jul 22, 2022

@Saul-Mirone Saul-Mirone added planned This issue is being planned in iteration and removed invalid This doesn't seem right labels Jul 22, 2022
@4-1-1
Copy link
Author

4-1-1 commented Aug 1, 2022

image

Just one line code

@Saul-Mirone
Copy link
Member

image

Just one line code

Not that simple, this will break something like bold code

@4-1-1
Copy link
Author

4-1-1 commented Aug 6, 2022

if you mean bold the text in code . **bold**.
it should be break

@Saul-Mirone
Copy link
Member

bold code

**`bold code`**

@stan12138
Copy link

stan12138 commented Aug 12, 2022

I have same problem. when I want input someting like:
the data_name should not same with data_label

in other markdown software like typora,I should input:

the `data_name` should not same with `data_label`

It will be like this:
image

but in milkdown it will be like this:
image

@Saul-Mirone Saul-Mirone added this to the [email protected] milestone Aug 14, 2022
@Saul-Mirone Saul-Mirone mentioned this issue Aug 29, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned This issue is being planned in iteration
Projects
None yet
Development

No branches or pull requests

3 participants