Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-MIP] "Valid while" precondition should be asserted and not take fee if it fails #20

Open
L-as opened this issue Aug 1, 2024 · 1 comment

Comments

@L-as
Copy link

L-as commented Aug 1, 2024

zkApp commands can currently fail and still take fees if the preconditions fail.
This is to allow for a simplified mempool design that does not need to take into account
transaction dependencies.

However, transaction ordering can not affect whether the "valid while" precondition fails,
thus, you can assert that it always succeeds, without changing the design of the mempool.
The only change you need is to discard the transaction if the precondition fails
on block production time, rather than trying to prove it.

@L-as
Copy link
Author

L-as commented Aug 1, 2024

@nholland94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant