Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port changes to rosetta-sdk-go to our own fork #12438

Closed
kantp opened this issue Jan 3, 2023 · 6 comments
Closed

Port changes to rosetta-sdk-go to our own fork #12438

kantp opened this issue Jan 3, 2023 · 6 comments

Comments

@kantp
Copy link
Member

kantp commented Jan 3, 2023

We are currently using a modified version of rosetta-sdk-go for testing of constructing transactions invoving delegations. Those modifications are currently in https://github.com/ylecornec/rosetta-sdk-go, but we want to have them in https://github.com/MinaProtocol/rosetta-sdk-go.

@kantp kantp added this to Rosetta-API Jan 3, 2023
@kantp kantp converted this from a draft issue Jan 3, 2023
@kantp
Copy link
Member Author

kantp commented Jan 3, 2023

@kaozenn said that https://github.com/MinaProtocol/rosetta-sdk-go seems to have some changes that are incompatible with the main repository at https://github.com/coinbase/rosetta-sdk-go, so the first task here will be to look at whether those changes are still relevant.

@Sventimir
Copy link
Contributor

Indeed, https://github.com/MinaProtocol/rosetta-sdk-go is no longer compatible with the main repository. There are 3 commits made in August 2020 and the repository seems to not have been updated ever since. It can be realtively easily rebased, but I think MinaProtocol/master should always reflect the main-line master. Therefore I'll rename the main branch and rebase it in case anyone needed it still (which I don't think is likely). Then I'll sync our master with the main-line. Finally, I'll clone Yves-Stan's work to yet another branch in our repo.

@Sventimir
Copy link
Contributor

In fact it seems that these commits were actually integrated into the main-line, albeit with some modifications.

@Sventimir
Copy link
Contributor

I renamed the stale master branch to master-old. I then set master to follow the main-line repository. Finally I cloned Yves-Stan's branch as pallas_signer_stake_delegation. It follows Yves-Stan's branch, but that is unlikely to change in the future. However, we might need to make some changes to it in case Coinbase requests it. In that case we won't be able to change Yves-Stan's code. I'm also not sure if we'll be able to replace his branch with ours in the existing PR. Maybe it'd be the easiest to close that PR and reopen our own?

@kantp
Copy link
Member Author

kantp commented Jan 3, 2023

Yes, that sounds like a good idea!

@kantp kantp moved this from Todo to In Progress in Rosetta-API Jan 3, 2023
@Sventimir
Copy link
Contributor

The new PR meant to replace the one by Yves-Stan: coinbase/mesh-sdk-go#464.

@kantp kantp moved this from In Progress to Done in Rosetta-API Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants