-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port changes to rosetta-sdk-go to our own fork #12438
Comments
@kaozenn said that https://github.com/MinaProtocol/rosetta-sdk-go seems to have some changes that are incompatible with the main repository at https://github.com/coinbase/rosetta-sdk-go, so the first task here will be to look at whether those changes are still relevant. |
Indeed, https://github.com/MinaProtocol/rosetta-sdk-go is no longer compatible with the main repository. There are 3 commits made in August 2020 and the repository seems to not have been updated ever since. It can be realtively easily rebased, but I think MinaProtocol/master should always reflect the main-line master. Therefore I'll rename the main branch and rebase it in case anyone needed it still (which I don't think is likely). Then I'll sync our master with the main-line. Finally, I'll clone Yves-Stan's work to yet another branch in our repo. |
In fact it seems that these commits were actually integrated into the main-line, albeit with some modifications. |
I renamed the stale |
Yes, that sounds like a good idea! |
The new PR meant to replace the one by Yves-Stan: coinbase/mesh-sdk-go#464. |
We are currently using a modified version of
rosetta-sdk-go
for testing of constructing transactions invoving delegations. Those modifications are currently in https://github.com/ylecornec/rosetta-sdk-go, but we want to have them in https://github.com/MinaProtocol/rosetta-sdk-go.The text was updated successfully, but these errors were encountered: