Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replayer, checkpoint when finished #13501

Closed
psteckler opened this issue Jun 28, 2023 · 1 comment
Closed

Replayer, checkpoint when finished #13501

psteckler opened this issue Jun 28, 2023 · 1 comment
Assignees
@psteckler

Comments

@psteckler
Copy link
Member

PR #13460 removed the checkpoint file generated by the replayer when finished, because it was invalid. The reasoning was, there might be transactions that did not complete a block.

But data is added to the archive db one block at a time, so we should always have complete blocks.

Something was wrong about how that checkpoint file was being generated. Restore the facility to generate that file, but be sure it's valid.
@psteckler psteckler self-assigned this Jun 28, 2023
@psteckler
Copy link
Member Author

Not sure what was wrong, added final checkpoint in #13600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psteckler psteckler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psteckler