Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.3] Custom block model geometry is not baked #10178

Closed
MrCrayfish opened this issue Nov 18, 2024 · 1 comment
Closed

[1.21.3] Custom block model geometry is not baked #10178

MrCrayfish opened this issue Nov 18, 2024 · 1 comment
Labels
1.21

Comments

@MrCrayfish
Copy link
Contributor

Fairly simple, BlockGeometryBakingContext#bake is missing from BlockModel patches.
@MrCrayfish MrCrayfish added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Nov 18, 2024
@autoforge autoforge bot added the 1.21 label Nov 18, 2024
@LexManos
Copy link
Member

Really need to figure out how to write game tests for the rendering stuff.
The main issue during the update was the removal of the override system in vanilla which caused a lot of these patches to get wonkey.
I dont have any tests for this so I can't be sure it works correctly. But I can patch in the function call.

@autoforge autoforge bot removed the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LexManos @MrCrayfish