Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "la planche a pain" #14

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Add "la planche a pain" #14

merged 3 commits into from
Apr 22, 2024

Conversation

Miou-zora
Copy link
Owner

image

@Miou-zora Miou-zora requested a review from emneo-dev April 22, 2024 12:13
@Miou-zora Miou-zora self-assigned this Apr 22, 2024
emneo-dev
emneo-dev requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@emneo-dev emneo-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, it is good overall

src/Vec3.zig Outdated
@@ -23,6 +23,26 @@ pub const Vec3 = struct {
};
}

pub fn mul(self: *const Self, other: Self) Vec3 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call it mulVec3 in case we need some f32 multiplications later.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Miou-zora Miou-zora merged commit 8d9bad6 into main Apr 22, 2024
7 checks passed
@Miou-zora Miou-zora deleted the bread_on_the_board branch April 22, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emneo-dev emneo-dev emneo-dev requested changes

Assignees

@Miou-zora Miou-zora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miou-zora @emneo-dev