Execute permission for cri-dockerd/cri-dockerd not set in cri-dockerd-0.3.0.amd64.tgz

[iliyan-s-petkov]

Hello and happy new year!

In the previous releases of the cri-dockerd (amd64.tgz), the execute flag was set for the cri-dockerd/cri-dockerd.

In 0.3.0 the execute flag is no longer set:

$ tar -tvf cri-dockerd-0.3.0.amd64.tgz
drwxr-xr-x 0 neersighted wheel 0 Dec 22 18:18 cri-dockerd/
-rw-r--r-- 0 neersighted staff 54652001 Dec 22 18:16 cri-dockerd/cri-dockerd

Is that by intention?

With the execute flag missing, during installation it has to be set, adding one more step to the installation process.

For reference:
$ tar -tvf ./cri-dockerd-0.2.1.amd64.tgz
drwxr-xr-x 0 rbarry rbarry 0 May 25 2022 cri-dockerd/
-rwxr-xr-x 0 rbarry rbarry 52331990 May 25 2022 cri-dockerd/cri-dockerd

[neersighted]

Looks like a duplicate/special case of #140 where I forgot to set the execute bit when manually preparing the archives. @evol262, do you want to upload new builds performed using your usual method?

[afbjorklund]

While you are at it, you might want to remove the user as well.

tar --owner=0 --group=0

And what about the linux ? It's a wild wild west, this business...

crictl-v1.26.0-linux-amd64.tar.gz (now where did that v come from?)

[evol262]

There's a pending PR where we can do the "re-vendor upstream k8s deps" dance (which is always really fun) which will end up in a new release. Do we think it's worth the time to re-build this one?

There's no linux because linux is the presumed default, and "not-linux (sort-of)" ends up with annotations about what it is. We could change that, too, but it doesn't make the wild wild west any less wild. We don't use CGO, but glibc, cosmopolitan libc, musl libc, gccgo, and a huge matrix of "Linux but different" options are also possible.

[afbjorklund]

it doesn't make the wild wild west any less wild.

And still prefer people to use the packages, anyway.

[afbjorklund]

Do we think it's worth the time to re-build this one?

Fixing it for the future sounds like the right approach

[evol262]

Rebuild it is then.

[afbjorklund]

I meant "for next time" (release), but sure.