Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Discussion) Kinesis batch window (MaximumBatchingWindowInSeconds) #1973

Open
spascou opened this issue Dec 19, 2019 · 0 comments
Open

(Discussion) Kinesis batch window (MaximumBatchingWindowInSeconds) #1973

spascou opened this issue Dec 19, 2019 · 0 comments

Comments

@spascou
Copy link

spascou commented Dec 19, 2019

I wanted to use batch window option for consuming Kinesis events, but did not find the corresponding setting in Zappa. Decided to implement it.

As the Kinesis Event Source currently used is the one provided by Kappa, I have opened a PR there as well (garnaat/kappa#139).
However, considering the activity level on the kappa repository, I'm thinking of adding it here on a short-to-mid-term basis (see https://github.com/spascou/Zappa/commit/62ca54ab3720eaaf3d27da635b7306f0b46f7c70).

To that end, I created an ExtendedKinesisEventSource in a similar fashion that has been done for SNS.

Are there any comments / suggestions on this? I'll open a PR here if it seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant